Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completing Chrisbirster new string with format #3027

Merged
merged 5 commits into from Jun 2, 2022
Merged

Completing Chrisbirster new string with format #3027

merged 5 commits into from Jun 2, 2022

Conversation

andydotxyz
Copy link
Member

Wrap up the good work started in #2942, but match our naming and return style.

Fixes #2890

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

  • Public APIs match existing style.

chrisbirster and others added 4 commits April 28, 2022 05:21
@chrisbirster
feat: NewStringWithFormat wrapper method
47a07cc
@andydotxyz
Merge branch 'new-string-with-format' of https://github.com/chrisbirs…
bd6e7a2 
…ter/fyne into chrisbirster-new-string-with-format
@andydotxyz
Remove some of the functionality of NewStringWithFormat and match o…
6a9a3a7 
…ther naming

Result is `StringToStringWithFormat`.
We could add `NewStringWithFormat` as a shorthand, but it doesn't quite fit... thoughts?
@andydotxyz
Also remove the NewSprintf err return
f28f392 
This does not match other constructors and is always nil
@andydotxyz andydotxyz changed the base branch from master to develop June 2, 2022 09:08
@andydotxyz andydotxyz mentioned this pull request Jun 2, 2022
Closed
7 tasks
@coveralls
Copy link

coveralls commented Jun 2, 2022 •
edited

Coverage Status

Coverage increased (+0.007%) to 61.372% when pulling 7ed5724 on andydotxyz:chrisbirster-new-string-with-format into efbf153 on fyne-io:develop.

Jacalz
Jacalz previously approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but I added a comment that you might want to look at before merging.

data/binding/sprintf.go Show resolved Hide resolved
@andydotxyz andydotxyz requested a review from Jacalz June 2, 2022 10:47
@andydotxyz andydotxyz merged commit 8c5ac40 into fyne-io:develop Jun 2, 2022
@andydotxyz andydotxyz deleted the chrisbirster-new-string-with-format branch June 2, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add binding.NewStringWithFormat
4 participants
@andydotxyz @coveralls @Jacalz @chrisbirster