Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vet and cleanup module dependencies #3016

Open
Jacalz opened this issue May 31, 2022 · 2 comments
Open

Vet and cleanup module dependencies #3016

Jacalz opened this issue May 31, 2022 · 2 comments
Labels
enhancement New feature or request meta Organized lists

Comments

@Jacalz
Copy link
Member

Jacalz commented May 31, 2022

Summary

We currently have 28 direct dependencies listed in the go.mod file on develop as of writing this (note that those are for all packages here and an app built with Fyne will have nowhere near that many dependencies). These dependencies have of course been added as they have been needed but they have, more or less, started to pile up (it is entirely natural that it happens; I don't mean anything bad by saying so) and I think it might be time that we look into seeing if we can improve our dependency list.

I propose that we look through the list and try to remove potential dependencies that we might not need and replace some with better alternatives if available. We should also try to move away from unmaintained dependencies for security and maintainability reasons.

The list

Below is a list of the dependencies that I have identified as needing a look through for one reason or another. Feel free to add more ones, suggest better alternatives and so on. PRs are of course also welcome.

Module Reason Status
github.com/Kodeworks/golang-image-ico Latest commit was in 2014. Replacement has started with #3008.
github.com/fredbi/uri Latest commit was in 2018. @Jacalz has contributed improvements upstream.
https://github.com/mcuadros/go-version Repository is archived and latest commit is from 2019.

These ones are basically only the ones that were apparently dead upstream. There might be more dependencies that simply are used in very few places and could be replaced with a few extra lines of code in the repository.

@Jacalz Jacalz added enhancement New feature or request meta Organized lists labels May 31, 2022
@andydotxyz
Copy link
Member

Image is something I am working on already (related to #3008) - in general we should be more active in the image formats that we/Go supports :).

Great ticket by the way, thanks.

@Bluebugs
Copy link
Contributor

We had a discussion when we linked with go-version. It is doing the job it needs to and its API is small enough that it shouldn't require much care. If we ever need to get something corrected from upstream, we can always revisit the topic and see if there is an alternative or repatriate it in the fyne project then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request meta Organized lists
Projects
None yet
Development

No branches or pull requests

3 participants