Emphasis in Markdown gives erroneous output in RichText

[jfjensen]

Describe the bug:

If I run the example code from #2589 and type in **hello** then no emphasis is added. The emphasis only appears when I add another *, which is obviously incorrect behavior.

The bug must be somewhere in the Markdown Renderer where the emphasis is handled.

To Reproduce:

Steps to reproduce the behaviour:

1. Type in **hello** into the editor panel on the left. No emphasis is added.
2. Then add another *.

Screenshots:

Device (please complete the following information):

• OS: Windows 11Pro
• Version: 10.0.22000
• Go version: 1.17
• Fyne version: v2.1.4

[andydotxyz]

Thanks for opening this, Apologies I did not notice it before commenting on the other thread where you mentioned this

[andydotxyz]

Confirmed, thanks for reporting

[d4x1]

@jfjensen
This is caused by codes here, the codes here rewrite the bold style for emphasis elements.
I try to fix it like this, it works but breaks some test cases.

I cannot come up with an elegant way, I think markdownRenderer.Render must be implemented in a better way just like
html render in github.com/yuin/goldmark.

@andydotxyz do you have any advice?

[d4x1]

Or I can rewrite markdown render. Is this welcomed?

[jfjensen]

@d4x1 Thanks for looking into this! Perhaps a total rewrite is indeed necessary?

[d4x1]

@d4x1 Thanks for looking into this! Perhaps a total rewrite is indeed necessary?

At least you can refer to my modification, it makes emphasis' behavior normal. :)

[andydotxyz]

I cannot come up with an elegant way, I think markdownRenderer.Render must be implemented in a better way just like html render in github.com/yuin/goldmark.

@andydotxyz do you have any advice?

No specific thoughts. We always prefer smallest change possible - but some times the implementation was going down a blind alley. As long as there is no change to the RichText API we don't need to worry.

It's a naive stack implementation, but could certainly be better.
I think the main confusion is around paragraph vs block level text, so it is possible that a smaller fix may be OK

[andydotxyz]

Maybe #3086 makes you a little happy? :)

[andydotxyz]

Merged for v2.22