Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer ANDROID_NDK_HOME over the ANDROID_HOME ndk-bundle location #2920

Merged
merged 1 commit into from Apr 20, 2022

Conversation

andydotxyz
Copy link
Member

@andydotxyz andydotxyz commented Apr 13, 2022

tidy order of operations to prefer more specific environment variable.

Fixes #2899

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.669% when pulling 3bc3766 on andydotxyz:fix/2899 into 96d8124 on fyne-io:develop.

Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep in mind that I don’t have an Android development environment set up. However, the code is short and readable while also making a lot of sense so I’ll approve it :)

@andydotxyz andydotxyz merged commit 29daed4 into fyne-io:develop Apr 20, 2022
@andydotxyz andydotxyz deleted the fix/2899 branch April 20, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants