Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for container.Remove() when removing everything #2847

Merged
merged 1 commit into from Mar 14, 2022
Merged

Add docs for container.Remove() when removing everything #2847

merged 1 commit into from Mar 14, 2022

Conversation

Jacalz
Copy link
Member

@Jacalz Jacalz commented Mar 14, 2022

Description:

This adds documentation to the container.Remove() method to mention that it is inefficient to use it for removing all elements inside the slice. This pattern was found in #2826 and #2775.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

andydotxyz
andydotxyz approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks

@Jacalz Jacalz merged commit ed8d41a into fyne-io:release/v2.1.x Mar 14, 2022
@Jacalz Jacalz deleted the remove-all-slow branch March 14, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz approved these changes

@Bluebugs Bluebugs Bluebugs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jacalz @andydotxyz @Bluebugs