Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some typos #2845

Merged
merged 2 commits into from Mar 15, 2022
Merged

fix some typos #2845

merged 2 commits into from Mar 15, 2022

Conversation

cuishuang
Copy link
Contributor

No description provided.

@cuishuang
fix some typos
db83201 
Signed-off-by: cuishuang <imcusg@gmail.com>
andydotxyz
andydotxyz requested changes Mar 14, 2022
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking at this. Unfortunately one of the changes breaks tests, as noted inline.

data/binding/convert_test.go Outdated Show resolved Hide resolved
@cuishuang
revert data/binding/convert_test.go
0024664 
Signed-off-by: cuishuang <imcusg@gmail.com>
andydotxyz
andydotxyz approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

If you start working on larger changes please work on develop or the latest release branch as we don't normally work on master.

@andydotxyz andydotxyz merged commit 7595a4b into fyne-io:master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cuishuang @andydotxyz