Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the fixed size ensuring size to the end of window setup #2829

Merged
merged 1 commit into from Mar 11, 2022

Conversation

andydotxyz
Copy link
Member

@andydotxyz andydotxyz commented Mar 8, 2022

Fixes order of operation issues such as #2819

Fixes #2819

Checklist:

  • Tests included. <- subtlety in render size for some Linux WM
  • Lint and formatter run with no errors.
  • Tests all pass.

@andydotxyz andydotxyz requested a review from Bluebugs March 8, 2022 22:30
@andydotxyz
Copy link
Member Author

Tagged @Bluebugs on this as I think you worked on this recently

@Bluebugs
Copy link
Contributor

This sadly doesn't fix @kheyse-oqton problem in #2800. It is still a progress as I get a 0x0 window (and crash) with master and the provided example. I think it is an issue where the proper size is only really known after the windows has been built.

@andydotxyz
Copy link
Member Author

I removed #2800 from the fix list earlier today, this remains just a fix for #2819 as the description states above.
Can it be reviewed on the merits of that regression fix please?

Copy link
Contributor

@Bluebugs Bluebugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit uneasy that it doesn't fix #2800 as this patch change the behavior in that issue, but I can see that it does improve the situation. So let's move forward with this.

@andydotxyz andydotxyz merged commit 520867c into fyne-io:release/v2.1.x Mar 11, 2022
@andydotxyz andydotxyz deleted the fix/2819 branch March 11, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants