Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue when last item of a composite line is non-text #2796

Merged
merged 1 commit into from Feb 19, 2022

Conversation

andydotxyz
Copy link
Member

Fixes #2695

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this really show the hovered line all the way to the end? Otherwise it's looking good.

image

@andydotxyz
Copy link
Member Author

That is a good question @Jacalz, but not one with a simple answer.
I'd agree that the visual outcome is not desirable - but if the element was something other than a link (image etc) should it take up the space? Maybe it is a special case for Hyperlink, or maybe the hyperlink should only underline under text instead of full width? I think it's a separate issue as if you put a link into a window content it will do the same outside of RichText.

@andydotxyz andydotxyz merged commit 1ea0b00 into fyne-io:release/v2.1.x Feb 19, 2022
@andydotxyz andydotxyz deleted the fix/2695 branch February 19, 2022 17:33
@Jacalz
Copy link
Member

Jacalz commented Feb 19, 2022

Okay, I see. I personally think it should only highlight under the actual text. Seems more sensible to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants