If FixedSize is set without a preferred size we should fall back to minimum #2794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bluebugs
requested changes
Feb 17, 2022
| if !visible && w.fixedSize && (w.requestedWidth == 0 || w.requestedHeight == 0) { | ||
| bigEnough := w.canvas.canvasSize(content.MinSize()) | ||
| w.Resize(bigEnough) | ||
| } |
There was a problem hiding this comment.
This look like a bit of duplicated code to me. Would it be possible to put most of the if tests along with the code inside the if in its own function?
There was a problem hiding this comment.
Yeah could do. Initially it seemed like longer code - but the duplication is undesirable, will fix
Bluebugs
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid crashes by being larger than 1x1
Fixes #2784
Checklist: