Look up config dir using XDG_CONFIG_HOME #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This switches the config dir lookup from hardcoded $HOME + /.config to reading the $XDG_CONFIG_HOME environment variable using [os.UserConfigDir()](https://pkg.go.dev/os#UserConfigDir). This has one very big improvement, it means that Fyne apps running in flatpak don't need to pass though access to the cache directory. For everyone else, it's basically no change unless a custom $XDG_CONFIG_HOME is set in some situation (our old way is still the fallback).
|
I figure that this could be in the release notes as something like "Fixed Preferences and Documents Storage APIs not working out of the box in flatpak". |
changkun
reviewed
Dec 1, 2021
andydotxyz
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This switches the config dir lookup from hardcoded
$HOME + /.configto reading the $XDG_CONFIG_HOME environment variable using os.UserConfigDir(). This has one very big improvement. It means that Fyne apps running in flatpak don't need to pass though access to the cache directory to use the preference and document storage API. For everyone else, it's basically no change unless a custom$XDG_CONFIG_HOMEis set in some situation (our old way is still the fallback).Checklist: