Fix #1196: Add svg support for app/window icon #2671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Jacalz
changed the title
Jacalz
requested changes
Nov 30, 2021
internal/painter/image.go
Outdated
| @@ -201,7 +201,8 @@ func isFileSVG(path string) bool { | |||
| return strings.ToLower(filepath.Ext(path)) == ".svg" | |||
| } | |||
|
|
|||
| func isResourceSVG(res fyne.Resource) bool { | |||
| // IsResourceSVG checks if given fyne Resource is svg or not | |||
There was a problem hiding this comment.
Suggested change
| // IsResourceSVG checks if given fyne Resource is svg or not | |
| // IsResourceSVG checks if the resource is an SVG or not. |
There was a problem hiding this comment.
@Jacalz Sorry for the delay done changes as suggested.
Jacalz
approved these changes
Nov 30, 2021
7 tasks
|
Great result thanks. I updated the description above because "Fixes" should just list the bug resolved, not all related PRs as well. |
andydotxyz
pushed a commit
that referenced
this pull request
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #1196
Checklist:
Where applicable:
go mod vendor).