Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard opens on widget.select on mobile #2598

Closed
HashimTheArab opened this issue Oct 30, 2021 · 9 comments
Closed

Keyboard opens on widget.select on mobile #2598

HashimTheArab opened this issue Oct 30, 2021 · 9 comments
Labels
blocker Items that would block a forthcoming release bug Something isn't working Driver:mobile Issues relating to the mobile driver specifically

Comments

@HashimTheArab
Copy link

Describe the bug:

When opening a widget.select on android (tested on android 11) it opens your keyboard

To Reproduce:

Steps to reproduce the behaviour:

  1. Create a widget.select
  2. Open it on android

Screenshots:

image

Example code:

Device (please complete the following information):

  • OS: Android
  • Version: 11
  • Go version: 1.17.2
  • Fyne version: 2.1.1
@HashimTheArab HashimTheArab added the unverified A bug that has been reported but not verified label Oct 30, 2021
@Jacalz
Copy link
Member

Jacalz commented Oct 30, 2021

This is a good catch. I think this is because of the implemented keyboard control for the focus on desktop.

@Jacalz Jacalz added bug Something isn't working Driver:mobile Issues relating to the mobile driver specifically and removed unverified A bug that has been reported but not verified labels Oct 30, 2021
@Jacalz Jacalz added this to the Fixes (v2.1.x) milestone Oct 30, 2021
@andydotxyz
Copy link
Member

Yes, interestingly I just noticed this yesterday too. We changed the contract for focusable so it did not automatically focus on tap - but that was only done on Desktop driver, needs to be mirrored in the mobile code.

@andydotxyz andydotxyz added the blocker Items that would block a forthcoming release label Oct 30, 2021
@HashimTheArab
Copy link
Author

Another thing, the widgets get pushed up when the keyboard is opened

mobizen_20211030_170755.mp4

@andydotxyz
Copy link
Member

Another thing, the widgets get pushed up when the keyboard is opened

This seems to vary based on device, can you please provide more information about your device make/model and Android variant?

@HashimTheArab
Copy link
Author

HashimTheArab commented Oct 31, 2021

Another thing, the widgets get pushed up when the keyboard is opened

This seems to vary based on device, can you please provide more information about your device make/model and Android variant?

Samsung Galaxy M31 (SM-M315F/DSN) running Android 11

@HashimTheArab
Copy link
Author

Any chance this'll be merged soon?

@Jacalz
Copy link
Member

Jacalz commented Nov 4, 2021

Things take time. Hold on to your hat and it will land when it lands. I have a lot of things to do at the moment. Might get tot it at the end of the week.

@andydotxyz
Copy link
Member

Fixed on release/v2.1.x ready for v2.1.2 release

@andydotxyz
Copy link
Member

Prepping for release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Items that would block a forthcoming release bug Something isn't working Driver:mobile Issues relating to the mobile driver specifically
Projects
None yet
Development

No branches or pull requests

3 participants