Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextGrid not always drawing correctly when resized #2501

Closed
vit1251 opened this issue Sep 23, 2021 · 5 comments
Closed

TextGrid not always drawing correctly when resized #2501

vit1251 opened this issue Sep 23, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@vit1251
Copy link

vit1251 commented Sep 23, 2021

During resize main window repaint may overlap and I think tat we have there race condition.
But it require more deeply research.

@vit1251 vit1251 added the unverified A bug that has been reported but not verified label Sep 23, 2021
@andydotxyz
Copy link
Member

Resize is an async operation, can you be more specific about what the fault is?

@vit1251
Copy link
Author

vit1251 commented Sep 23, 2021

On Linux platform during resize invoke blinking with repaint text and as you can see on picture in some cases it cause and broke content in line 2 should be "TO: 'A" but instead we see an "TTO ".

@andydotxyz andydotxyz changed the title TextGrid race condition on repaint after resize layout TextGrid not always drawing correctly when resized Sep 24, 2021
@andydotxyz andydotxyz added the bug Something isn't working label Sep 24, 2021
@andydotxyz andydotxyz added this to the Fixes (v2.1.x) milestone Sep 24, 2021
@andydotxyz andydotxyz removed the unverified A bug that has been reported but not verified label Sep 27, 2021
@andydotxyz
Copy link
Member

Thanks for clarifying. I see now an issue with how cells are re-used so resize can cause glitches. This needs addressed

@smcio
Copy link
Contributor

smcio commented Oct 17, 2021

I can reproduce this issue using @vit1251 's fyne-viewer code here: https://github.com/vit1251/fyne-viewer

The visual symptoms (i.e. visual text corruption) are much easier to reproduce when using Fyne's current 'develop' branch vs. when using the 'master' branch, but the problem does also occur on the 'master' branch, for me, nonetheless.

I found that the fix implemented by nullst here (#2548) (and PR here: #2555) for a different bug report actually seems to fix this issue as well - at least as far as I can tell visually whilst trying to repro by resizing. I don't know if there's some other underlying problem that is not fixed, though - I'm just commenting here w.r.t. visual symptoms after applying the proposed fix for issue 2548. :)

@andydotxyz
Copy link
Member

This should now be resolved on develop and release branch :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants