Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing clicks inside file dialog #2484

Closed
alexballas opened this issue Sep 19, 2021 · 4 comments
Closed

Missing clicks inside file dialog #2484

alexballas opened this issue Sep 19, 2021 · 4 comments
Labels
unverified A bug that has been reported but not verified

Comments

@alexballas
Copy link
Contributor

alexballas commented Sep 19, 2021

Describe the bug:

My app is missing clicks when inside the file dialog. At first I thought it was my idea. I tried a different mouse and started clicking fast the various predefined locations to the left (Home/Computer/Documents etc) or just select files. Not all my clicks will trigger the buttons.

Steps to reproduce:

  • Open file dialog
  • Client randomly (and quickly) the various buttons or files.
  • You'll notice that some clicks wont go through
  • Click speed seems to affect this. Keeping a delay between my mouse clicks seems to not cause any misses

Device (please complete the following information):

  • OS: Ubuntu 18.04
  • Go version: 1.7.1
  • Fyne version: 2.1.0

I dont have the same issue with release 2.0.3

@alexballas alexballas added the unverified A bug that has been reported but not verified label Sep 19, 2021
@tandem97
Copy link

image
Have the same problem on win 10

@alexballas
Copy link
Contributor Author

Raised PR #2492

@andydotxyz
Copy link
Member

Thanks for the fix @alexballas , this is now on develop for wider testing.

@andydotxyz
Copy link
Member

Pushed a better fix. The initial one actually created a test failure that we missed (drag up should not result in click).
I realised this change was just hiding an issue that we'd not fixed, just painted over.
Now we don't trigger a drag until > 1pt move - and when it does drag no tap event is emitted.
This fixes the original issue and the test failure resulting from the first change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unverified A bug that has been reported but not verified
Projects
None yet
Development

No branches or pull requests

3 participants