Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ico file when compiling for windows #2412

Closed
zivoy opened this issue Aug 29, 2021 · 2 comments
Closed

Add support for ico file when compiling for windows #2412

zivoy opened this issue Aug 29, 2021 · 2 comments
Labels
blocker Items that would block a forthcoming release enhancement New feature or request Hacktoberfest

Comments

@zivoy
Copy link
Contributor

zivoy commented Aug 29, 2021

Is your feature request related to a problem? Please describe:

It is currently not possible to use a .ico file as an icon for the app using the fyne.Window.SetIcon function, though this might be a bit harder to do on OS's that are not Windows.
BUT when compiling for windows you also can't use a .ico file, it tries to make a .ico file from a format it can read (png)

img

Is it possible to construct a solution with the existing API?

You can use a png as the app icon and as the desktop icon

Describe the solution you'd like to see:

At least when compiling for Windows and you supply a .ico file it should use it instead of trying to make a new one

Note:

This was discussed here on the Discord Gophers discord

@andydotxyz andydotxyz changed the title Use an ico file when compiling for windows Add support for ico file when compiling for windows Aug 30, 2021
@andydotxyz andydotxyz added the enhancement New feature or request label Aug 30, 2021
@andydotxyz andydotxyz added the blocker Items that would block a forthcoming release label Mar 11, 2022
@andydotxyz
Copy link
Member

This issue mentions a couple of different items.
It was discussed to day that:

  • Fyne (and fyne-cross too) should support packaging with a windows icon
  • SetIcon does not have to process windows icon files as it uses Go image decoders, and all images should be cross-platform formats, or a custom image decoder loaded in your app.

So we will progress with fixing the packaging issue.

@andydotxyz
Copy link
Member

On develop for v2.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Items that would block a forthcoming release enhancement New feature or request Hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants