Use __send__ instead of send

[mfilej]

We had an issue in our codebase where we would see a mysterious ArgumentError - wrong number of arguments (given 2, expected 3) that was being traced to this line:

(gem) zeitwerk-2.3.0/lib/zeitwerk/loader.rb:796:in `unload_autoload'

We finally realized that this is down to a class in our codebase that defines its own self.send method (that does something unrelated, hence the mismatch in arity).

Now I'm completely aware that this is bad practice and we're going to fix the offending class, but it's also true that the resulting error message is very confusing and it's not immediately clear how to fix it.

If zeitwerk was to use __send__ instead of send it would avoid this issue. I'm not sure if there are any downsides to this, or if this should be merged at all -- consider this pull request an invitation for a discussion.

[casperisfine]

Another possibility would be the same trick we use for Module#name: https://github.com/fxn/zeitwerk/blob/60021d90af973d98ee19e9634a552b25c39320cc/lib/zeitwerk/real_mod_name.rb

But yeah __send__ is very unlikely to be redefined.

[fxn]

❤️

[fxn]

Version 2.4.1 is out with this fix, thanks!