Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is ignoreClass value within the examples outdated? #1370

Open
santiagos01 opened this issue Jan 27, 2024 · 1 comment
Open

Is ignoreClass value within the examples outdated? #1370

santiagos01 opened this issue Jan 27, 2024 · 1 comment

Comments

@santiagos01
Copy link

santiagos01 commented Jan 27, 2024 •
edited

Noticed that the value for ignoreClass within the examples is annotator-hl (e.g., in highlights.html).
However, it seems that the default class name for highlighting is epubjs-hl (source).
Are the examples outdated?
@johnfactotum
Copy link
Contributor

I could be wrong but I believe the annotator-hl class is for the Hypothesis Client only. For highlights created by Epub.js, they are not injected into the content so there's nothing to ignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnfactotum @santiagos01