Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong return type of Rendition.currentLocation() #1311

Open
hchengx opened this issue Dec 22, 2022 · 0 comments · May be fixed by #1339
Open

wrong return type of Rendition.currentLocation() #1311

hchengx opened this issue Dec 22, 2022 · 0 comments · May be fixed by #1339

Comments

@hchengx
Copy link

hchengx commented Dec 22, 2022

Thank you for your great work. But something wrong found in rendition.d.ts.

Function currentLocation() should return Location but return DisplayedLocation.
@sbatson5 sbatson5 linked a pull request Jun 7, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

list proper types for currentLocation Upstatement/epub.js
1 participant
@hchengx