From 7a7ffd8c159d924f6f68d13bad251a9270ddc828 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Arnaud=20Barr=C3=A9?= Date: Sat, 17 Dec 2022 15:09:16 +0100 Subject: [PATCH] fix: skip applescript when no Chromium browser found (fixes #11205) (#11406) --- packages/vite/src/node/server/openBrowser.ts | 24 +++++++++++--------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/packages/vite/src/node/server/openBrowser.ts b/packages/vite/src/node/server/openBrowser.ts index bf2a383d6b7aba..915328ce9efb83 100644 --- a/packages/vite/src/node/server/openBrowser.ts +++ b/packages/vite/src/node/server/openBrowser.ts @@ -86,17 +86,19 @@ function startBrowserProcess(browser: string | undefined, url: string) { preferredOSXBrowser && ps.includes(preferredOSXBrowser) ? preferredOSXBrowser : supportedChromiumBrowsers.find((b) => ps.includes(b)) - // Try our best to reuse existing tab with AppleScript - execSync( - `osascript openChrome.applescript "${encodeURI( - url, - )}" "${openedBrowser}"`, - { - cwd: join(VITE_PACKAGE_DIR, 'bin'), - stdio: 'ignore', - }, - ) - return true + if (openedBrowser) { + // Try our best to reuse existing tab with AppleScript + execSync( + `osascript openChrome.applescript "${encodeURI( + url, + )}" "${openedBrowser}"`, + { + cwd: join(VITE_PACKAGE_DIR, 'bin'), + stdio: 'ignore', + }, + ) + return true + } } catch (err) { // Ignore errors }