You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
/// let bytes = byte_stream.next().await.unwrap().unwrap();
The issue: byte_stream.next()only read the first frame(the default capacity is 8k), not the complete content for large tar file.
Think aloud, import_image use Bytes as root_fs's type, which means we should read the tar file into memory one time, If the file is several gigabytes, this will be annoying.
The text was updated successfully, but these errors were encountered:
Yes, I believe it's bounded by 8k due to tokio's default Framing configuration ... happy to take any PR adjustments to make this better.
Re. your second point, it got changed to Bytes because Hyper changed Body to become less dependent on Tokio. Is there an obvious streaming byte implementation to use here, one that also doesn't use Tokio ?
bollard/src/image.rs
Line 1351 in d258ede
The issue:
byte_stream.next()
only read the first frame(the default capacity is 8k), not the complete content for large tar file.Think aloud,
import_image
useBytes
asroot_fs
's type, which means we should read the tar file into memory one time, If the file is several gigabytes, this will be annoying.The text was updated successfully, but these errors were encountered: