Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

class NoAnsi is missing override methods #215

Closed
cbcmg opened this issue Jul 14, 2021 · 0 comments · May be fixed by gnodet/jansi#1
Closed

class NoAnsi is missing override methods #215

cbcmg opened this issue Jul 14, 2021 · 0 comments · May be fixed by gnodet/jansi#1
Milestone
2.3.4

Comments

@cbcmg
Copy link

cbcmg commented Jul 14, 2021 •
edited

NoAnsi has

public Ansi fg(Color color) {return this;}

but not

public Ansi fgRgb(int color){return this;}

which means when Ansi.setEnabled(false) and e.g. println(ansi().fgRgb(0x808080).a(x).reset() escape sequences are still output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.4
Development

Successfully merging a pull request may close this issue.

Fix wrong output encoding on Windows with JDK >= 19 (fixes #247) gnodet/jansi
2 participants
@gnodet @cbcmg