You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially I tried to test if the method would throw an I/O Exception or not but I soon realised that the method itself never throws an Exception because it would already have been handled by the try-catch block in ClientHandler. I have therefore tested whether or not an error message has been logged in order to determine if an exception has been thrown.
Any input or improvements would be greatly appreciated 馃檪.
The reason will be displayed to describe this comment to others. Learn more.
What about the doThrow() method form the mockito library. Where you can check if any exception has been thrown when a class's method gets called
Would this solve your first id茅a?
Should we check if errormessages is greater than 0 instead of equal to 1?
What about the doThrow() method form the mockito library. Where you can check if any exception has been thrown when a class's method gets called Would this solve your first id茅a?
Should we check if errormessages is greater than 0 instead of equal to 1?
I tried to throw an I/O Exception for Mockito.doThrow(IOException.class).when(socket.getInputStream()); but the exception is handled within the method's try-catch block and it does not throw an exception itself. The method will only log an error message if an exception has occured. assertThatIOException().isThrownBy(clientHandler::run); is always false even if the socket is closed.
What about the doThrow() method form the mockito library. Where you can check if any exception has been thrown when a class's method gets called Would this solve your first id茅a?
Should we check if errormessages is greater than 0 instead of equal to 1?
I tried to throw an I/O Exception for Mockito.doThrow(IOException.class).when(socket.getInputStream()); but the exception is handled within the method's try-catch block and it does not throw an exception itself. The method will only log an error message if an exception has occured. assertThatIOException().isThrownBy(clientHandler::run); is always false even if the socket is closed.
The run method only logs 1 message and it may similarly be an issue of concern if it deviates from its expected behaviour and logs 2 messages instead. That would then possibly be a bug in our logging system.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #42
Initially I tried to test if the method would throw an I/O Exception or not but I soon realised that the method itself never throws an Exception because it would already have been handled by the
try-catchblock in ClientHandler. I have therefore tested whether or not an error message has been logged in order to determine if an exception has been thrown.Any input or improvements would be greatly appreciated 馃檪.