Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream#foldRight1 naming #242

Open
jbgi opened this issue Mar 18, 2016 · 0 comments
Open

Stream#foldRight1 naming #242

jbgi opened this issue Mar 18, 2016 · 0 comments

Comments

@jbgi
Copy link
Member

jbgi commented Mar 18, 2016

Stream foldRight1 methods at https://github.com/functionaljava/functionaljava/blob/master/core/src/main/java/fj/data/Stream.java#L146
are named as if the stream must be non-empty but this is not the case.
I think we should either use A => B as initial value (to conform with the name, but unsafe) . Or rename to something like foldRight<Eager|Strict|?>. Or have both...
WDYT ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant