Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go1.18 support; set go1.18 in Dockerfile #196

Merged
merged 2 commits into from Aug 4, 2022
Merged

Add go1.18 support; set go1.18 in Dockerfile #196

merged 2 commits into from Aug 4, 2022

Conversation

gpassini
Copy link
Contributor

@gpassini gpassini commented Aug 4, 2022

No description provided.

@gpassini gpassini marked this pull request as ready for review August 4, 2022 20:00
Copy link
Member

@dragonsinth dragonsinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM by inspection, but IDK why CI didn't run?

@dragonsinth
Copy link
Member

@gpassini
Copy link
Contributor Author

gpassini commented Aug 4, 2022

This LGTM by inspection, but IDK why CI didn't run?

I don't know why the CI tests reporting is stuck, but it seems to be the case only on GitHub's side, and it's the same for all currently open PRs.

Given the checks are green, is there anything else I should check before merging this?

@dragonsinth
Copy link
Member

Merge away

@gpassini
Copy link
Contributor Author

gpassini commented Aug 4, 2022

Merge away

Actually, I'm blocked by the missing status reports :(

@habib habib merged commit 410c0c3 into master Aug 4, 2022
@habib habib deleted the go118 branch August 4, 2022 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants