updates the grpcui client to show error details on response tab #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example of the response tab when an error has details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a TODO in the code to actually show the error details in the client UI. They were correctly processed by the server and sent to the client, but the client was doing nothing with that data.
Also includes a new endpoint on the
testsvr, so it's easy to invoke an RPC that returns an error with details (for testing).Fixes #135.
While refactoring the response rendering, I also moved the line that captures the duration of the call, so that it no longer includes any other response processing or rendering time.
Fixes #116.