explicitly wrap flush LocalFileOpener #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrba
changed the title
|
Thanks for the fix. I suppose getattr is actually never called when the method is available (but not implemented) in the superclasses, you are right. You are welcome to add more specific known methods of a file here, I don't mind - or we can merge as is, since it solves your problem. Thanks for the digging, I like the weird effect the bug has, of swapping the header and data portions of the output. |
|
I suggest to merge just this fix. Removing getattr without replacement breaks a couple of tests. Replacing it by explicit overrides will most likely resolve it. But I won't do that right now. |
|
OK, merging when green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving #1057.