Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registry: add asynclocalfs to the registry #1060

Merged
merged 2 commits into from Oct 3, 2022

Conversation

skshetry
Copy link
Contributor

@skshetry skshetry commented Oct 3, 2022

We need a new fsspec release to take advantage of disabled-mirroring for faster sync methods in AsyncLocalFileSystem, but I think we can add it to the registry even without it (I also need to make a release there). :)

Closes #1052.

@martindurant
Copy link
Member

Do you already refer to it as "asynclocalfs" elsewhere? The other protocols do not normally include "fs" in their names, even though all are filesystems.

@skshetry
Copy link
Contributor Author

skshetry commented Oct 3, 2022

I do use it on entry points, but I can change it to asynclocal. It did not sound good to me before, so I added fs to it. :)

fsspec/registry.py Outdated Show resolved Hide resolved
@martindurant
Copy link
Member

+1

@martindurant martindurant merged commit 3969aaf into fsspec:master Oct 3, 2022
@skshetry skshetry deleted the add-asynclocalfs branch October 3, 2022 17:26
@skshetry
Copy link
Contributor Author

skshetry commented Oct 3, 2022

Hey @martindurant, would you be able to tag a new release, please? 🙏🏼

@martindurant
Copy link
Member

Keep pinging me until it happens :). Now targeting Friday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Async LocalFileSystem
2 participants