Is RunSettingsArguments being used? #2376
Labels
Comments
|
Yes looks like it. Should we implement or remove it? I guess you can just use the |
|
I tried that but it looks like common args are being placed before
everything else so it results in stuff getting ignored because of the --
prefix
…On Sat, 17 Aug 2019, 14:00 Matthias Dittrich, ***@***.***> wrote:
Yes looks like it. Should we implement or remove it? I guess you can just
use the Common field for this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2376>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVO3M2MGFOLIXB446S5Q73QE7K4PANCNFSM4IMMRVMA>
.
|
|
Would come up with a PR but looks like it's not particularly straightforward
On Sat, 17 Aug 2019, 14:30 Eirik George Tsarpalis, <
eirik.tsarpalis@gmail.com> wrote:
… I tried that but it looks like common args are being placed before
everything else so it results in stuff getting ignored because of the --
prefix
On Sat, 17 Aug 2019, 14:00 Matthias Dittrich, ***@***.***>
wrote:
> Yes looks like it. Should we implement or remove it? I guess you can just
> use the Common field for this?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#2376>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAVO3M2MGFOLIXB446S5Q73QE7K4PANCNFSM4IMMRVMA>
> .
>
|
|
to be honest I don't know what arguments this should be used for and how it relates to the possible msbuild, dotnet cli and dotnet runtime arguments. Or where these |
|
Afk atm, but in essence this is what it looks like:
```
dotnet test -c Release -f netcoreapp2.2 --
RunSettingsArguments.DisableAppDomain=true
```
If I place the runsettings arguments in Common, it will render as follows
```
dotnet test -- RunSettingsArguments.DisableAppDomain=true -c Release -f
netcoreapp2.2
```
Which results in the -c and -f switches being ignored by dotnet cli (this
is because of the -- delimiter)
I tried maybe hijacking via msbuild args (which are rendered at the end of
the args strings) however arbitrary strings are currently not allowed there.
Will follow up with concrete examples once I get access to a PC.
…On Sat, 17 Aug 2019, 14:36 Matthias Dittrich, ***@***.***> wrote:
to be honest I don't know what arguments this should be used for and how
it relates to the possible msbuild, dotnet cli and dotnet runtime
arguments. Or where these RunSettingsArguments logically belong to. So a
PR with examples would be appreciated. Or just some examples on what this
should be used for (maybe with links to existing docs)?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2376>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVO3M6FFHIKNSYJLSFUCZDQE7PDBANCNFSM4IMMRVMA>
.
|
|
There has not been any activity in this issue for the last 3 months so it will be closed in 14 days if there is no activity. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
It seems that the
DotNet.TestOptions.RunSettingsArgumentsproperty is dead code?The text was updated successfully, but these errors were encountered: