Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation - Shell Command sanitized? #2696

Open
ShalokShalom opened this issue Sep 4, 2022 · 0 comments
Open

Documentation - Shell Command sanitized? #2696

ShalokShalom opened this issue Sep 4, 2022 · 0 comments

Comments

@ShalokShalom
Copy link
Contributor

Description

I wonder if the ShellCommand and RawCommand runners are safe.

Repro steps

Please provide the steps required to reproduce the problem

  1. visit documentation at https://fake.build/apidocs/v5/fake-core-command.html

  2. Wonder, whatever or not, both APIs provide a sanitized interface.

Expected behavior

ShellCommand (which is probably unsafe) being described as vulnerable to malicious user code.

RawCommand (which is probably safe) being described as sanitized.

Actual behavior

No mention of security at all.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ShalokShalom