Wrong version of MSBuild found if only Visual Studio 2022 is installed

[NogginBops]

This code only looks in the Program Files (x86) folder for Visual Studio installations, but vs2022 installs in Program Files, so MSBuild provided with vs2022 will not be picked up by Fake.DotNet.MSBuild.

FAKE/src/app/Fake.DotNet.MSBuild/MSBuild.fs

Lines 236 to 249 in e313c3b

	let findOnVSPathsThenSystemPath =
	let visualStudioVersion = Environment.environVarOrNone "VisualStudioVersion"
	let vsVersionPaths =
	let dict = toDict knownMSBuildEntries
	defaultArg (visualStudioVersion |> Option.bind dict.TryFind) getAllKnownPaths
	|> List.map ((@@) Environment.ProgramFilesX86)
	let vsWhereVersionPaths =
	let orderedVersions = MSBuildExeFromVsWhere.getOrdered()
	let all = orderedVersions |> List.collect (fun e -> e.Paths)
	let dict = toDict orderedVersions
	defaultArg (visualStudioVersion |> Option.bind dict.TryFind) all
	let fullList = vsWhereVersionPaths @ vsVersionPaths |> List.distinct
	Process.tryFindFile fullList "MSBuild.exe"

[github-actions]

Welcome to the FAKE community! Thank you so much for creating your first issue and therefore improving the project!

[aloisdg]

Nice catch. Maybe we should hardcoded the program file into each paths or we can write a small logic:

pseudo code

// wont work because visualStudioVersion can be none
let getProgramFilesPath visualStudioVersion = 
    if (float visualStudioVersion) < 17.0
	then Environment.ProgramFilesX86
	else Environment.ProgramFiles

let findOnVSPathsThenSystemPath =
                let visualStudioVersion = Environment.environVarOrNone "VisualStudioVersion"
Environment.ProgramFiles
                let vsVersionPaths =
                    let dict = toDict knownMSBuildEntries
                    defaultArg (visualStudioVersion |> Option.bind dict.TryFind) getAllKnownPaths
                    |> List.map (fun path -> (getProgramFilesPath visualStudioVersion) @@ path)
                let vsWhereVersionPaths =
                    let orderedVersions = MSBuildExeFromVsWhere.getOrdered()
                    let all = orderedVersions |> List.collect (fun e -> e.Paths)
                    let dict = toDict orderedVersions
                    defaultArg (visualStudioVersion |> Option.bind dict.TryFind) all
                let fullList = vsWhereVersionPaths @ vsVersionPaths |> List.distinct

source:

• https://docs.microsoft.com/en-us/dotnet/api/system.environment.specialfolder?view=net-6.0
• https://docs.microsoft.com/en-us/visualstudio/install/change-installation-locations?view=vs-2022

[yazeedobaid]

Thanks for reporting!
Would anyone like to send a PR for this issue?

[aloisdg]

@yazeedobaid I am willing to transform my pseudo code into something useful.

[yazeedobaid]

@aloisdg thanks