Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix upload response structure #843

Merged
merged 1 commit into from Jun 26, 2022
Merged

Fix upload response structure #843

merged 1 commit into from Jun 26, 2022

Conversation

barathsriram
Copy link
Contributor

The API response returned for the Upload Endpoints by the fake-gcs-server differs from the response documented in Google for the insert endpoint.

Reference: https://cloud.google.com/storage/docs/json_api/v1/objects/insert#response

@quettabit
Copy link

quettabit commented Jun 26, 2022 •
edited

we are facing the same issue when trying to call these APIs (served in a container) from rust. would be great if this gets merged. i think this fully addresses #420 ? @fsouza WDYT?

fsouza
fsouza approved these changes Jun 26, 2022
View reviewed changes
Copy link
Owner

@fsouza fsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing.

Do you think we could add a failing test? Or a failing example to the examples folder? I can merge this one and we can take care of testing in a follow-up though.

@fsouza fsouza merged commit fead2bb into fsouza:main Jun 26, 2022
@fsouza fsouza mentioned this pull request Sep 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsouza fsouza fsouza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@barathsriram @quettabit @fsouza