Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resumable uploads don't set content-type #532

Closed
fsouza opened this issue Jul 13, 2021 · 1 comment · Fixed by #924 · May be fixed by #845
Closed

Resumable uploads don't set content-type #532

fsouza opened this issue Jul 13, 2021 · 1 comment · Fixed by #924 · May be fixed by #845
Labels
bug

Comments

@fsouza
Copy link
Owner

fsouza commented Jul 13, 2021

Somehow exposed by #530, but resumable uploads don't set content-type and an empty Content-Type header can break the .NET SDK in that specific example.

Additionally, we should consider not setting the content-type header if we don't have it.
@fsouza fsouza added the bug label Jul 13, 2021
@fsouza fsouza mentioned this issue Jul 13, 2021
Closed
fsouza added a commit that referenced this issue Jul 13, 2021
@aeaton-overleaf @fsouza
Add file download to node example (#530)
cd0b800 
* Add file download to node example

* Set validation: false

* Set X-Goog-Hash header on download response

* Add both crc32c and md5

* Remove fixed comment.

* Don't set empty content-type header on download

Temporary workaround for #532 so we can get this PR in.

Co-authored-by: francisco souza <108725+fsouza@users.noreply.github.com>
Co-authored-by: francisco souza <fsouza@users.noreply.github.com>
@aheritier
Copy link

I confirm that real uploads on GCS are setting the content-type but somehow it is lost when using fake-gcs-server

@quettabit quettabit mentioned this issue Jun 29, 2022
Open
@barathsriram barathsriram mentioned this issue Jun 29, 2022
Draft
2 tasks
@ekimekim ekimekim mentioned this issue Jul 8, 2022
Closed
@fsouza fsouza mentioned this issue Sep 21, 2022
Merged
@otherguy otherguy mentioned this issue Mar 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for gzip transcoding
[Draft] Fix resumable upload barathsriram/fake-gcs-server
2 participants
@fsouza @aheritier