Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom metadata missing in Public and Signed URLs #1019

Closed
uddhav opened this issue Dec 25, 2022 · 0 comments · Fixed by #1020
Closed

Custom metadata missing in Public and Signed URLs #1019

uddhav opened this issue Dec 25, 2022 · 0 comments · Fixed by #1020

Comments

@uddhav
Copy link
Contributor

uddhav commented Dec 25, 2022

I noticed that the existing implementation does not provide the custom metadata with the x-goog-meta- prefix as indicated here.

I am creating this issue with the intention of submitting a PR. However, I am not a golang dev so feel free to turn it down.
uddhav pushed a commit to uddhav/fake-gcs-server that referenced this issue Dec 25, 2022
Custom metadata missing in Public and Signed URLs fsouza#1019
0a1ed04
@uddhav uddhav mentioned this issue Dec 25, 2022
Merged
fsouza added a commit that referenced this issue Dec 28, 2022
@uddhav @fsouza
Custom metadata missing in Public and Signed URLs #1019 (#1020)
a72af60 
* Custom metadata missing in Public and Signed URLs #1019

* Update fakestorage/object.go

Co-authored-by: Uddhav Kambli <ukambli@wayfair.com>
Co-authored-by: fsouza <108725+fsouza@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Custom metadata missing in Public and Signed URLs #1019 uddhav/fake-gcs-server
1 participant
@uddhav