New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable tests for PRs #415
Conversation
I imagine that disabling for PRs may have been needed to unbreak things while cleaning up the older releases in the test matrix. It would be good to re-enable tests on PRs.
Ah, lint is unhappy. I think there are other PRs that relate. |
@shogo82148 Do you think it will be easy to safely clean up the lint errors? Should we re-enable tests and for now just ensure that no NEW lint failures creep in? |
I don't think this is necessary. Opening a pull request is also a push. If you look through the checks, you can see twice as many tests runs as needed. Trying to save some cycles. If you want to take a closer look at GitHub's docs for Actions, I only looked at the very first example I saw, which was on push only. As far as linting, #382 attempts to do that, but there's a lot there. Maybe it would make sense to disable the linting until it's fixed, or even selectively disable certain errors that are "TODOs" to fix. At least then the build would pass? |
I opened #416 for fixing the lint.
That's right.
Generally speaking, |
The |
Do you need both push and pull_request though? I'd prefer just one or the other - either one. Btw, the |
We can also add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like wasting cycles, but if you feel it's helpful, then 👌🏼
Worse than wasting computer cycles is wasting maintainer cycles looking for things that computers could have caught. |
I imagine that disabling testing for PRs may have been needed to unbreak things while cleaning up the older releases in the test matrix.
It would be good to re-enable tests on PRs.