From 1c984ca31c4bdd23c2042dbff92a4c4aab212f97 Mon Sep 17 00:00:00 2001 From: Brian Goff Date: Mon, 4 Mar 2019 11:11:11 -0800 Subject: [PATCH 1/3] only run golint on latest version of go --- .travis.yml | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index 568aaa12..f7ea0542 100644 --- a/.travis.yml +++ b/.travis.yml @@ -3,24 +3,29 @@ language: go go: - "stable" - - "1.10.4" + - "1.11.x" + - "1.10.x" - "1.9.x" - "1.8.x" matrix: + include: + - go: "stable" + env: GOLINT=true allow_failures: - go: tip fast_finish: true -before_script: - - go get -u golang.org/x/lint/golint + +before_install: + - if [ ! -z "${GOLINT}" ]; then go get -u golang.org/x/lint/golint; fi script: - go test --race ./... after_script: - test -z "$(gofmt -s -l -w . | tee /dev/stderr)" - - test -z "$(golint ./... | tee /dev/stderr)" + - if [ ! -z "${GOLINT}" ]; then echo running golint; golint --set_exit_status ./...; else echo skipping golint; fi - go vet ./... os: From f1d474829a54ffe6a832c324474226d923292150 Mon Sep 17 00:00:00 2001 From: Brian Goff Date: Thu, 7 Mar 2019 19:54:56 -0800 Subject: [PATCH 2/3] Fix lint issue with error doc string --- fsnotify.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fsnotify.go b/fsnotify.go index 190bf0de..89cab046 100644 --- a/fsnotify.go +++ b/fsnotify.go @@ -63,4 +63,6 @@ func (e Event) String() string { } // Common errors that can be reported by a watcher -var ErrEventOverflow = errors.New("fsnotify queue overflow") +var ( + ErrEventOverflow = errors.New("fsnotify queue overflow") +) From 7141d0edcf3f8b3f88c421ff4288199adede38d9 Mon Sep 17 00:00:00 2001 From: Brian Goff Date: Thu, 7 Mar 2019 22:23:41 -0800 Subject: [PATCH 3/3] Add windows to travis matrix --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index f7ea0542..9071560b 100644 --- a/.travis.yml +++ b/.travis.yml @@ -31,6 +31,7 @@ after_script: os: - linux - osx + - windows notifications: email: false