Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

watcher.Close() is hanging forever on OSX #89

Closed
ryanwalls opened this issue Aug 26, 2015 · 5 comments · Fixed by #480
Closed

watcher.Close() is hanging forever on OSX #89

ryanwalls opened this issue Aug 26, 2015 · 5 comments · Fixed by #480
Assignees
@nathany
Labels
macOS

Comments

@ryanwalls
Copy link

I'm using the standard pattern presented in the samples file. Running the watcher from within a unit test and the unit test never exits when watcher.Close() is called.

Let me know what details would be useful.
@nathany
Copy link
Contributor

nathany commented Aug 29, 2015

If you can share some sample code to reproduce the issue, that would be helpful..

@nathany nathany added the macOS label Aug 29, 2015
@nathany nathany self-assigned this Aug 29, 2015
@omeid
Copy link

omeid commented Aug 29, 2015

The example doesn't check if watcher.Events is closed, so after calling watcher.Close() the outer select would block forever, assuming there are no errors.

@pquerna
Copy link

pquerna commented Apr 13, 2016

I was having similar issues on OSX, and PR #124 fixed them for me.

@pquerna pquerna mentioned this issue Apr 14, 2016
Closed
@nhooyr
Copy link
Contributor

nhooyr commented Jan 10, 2018 •
edited

I believe this is fixed in #230 @nathany so closing.

@nhooyr nhooyr closed this as completed Jan 10, 2018
@nhooyr
Copy link
Contributor

nhooyr commented Jan 10, 2018 •
edited

Never mind, seems unrelated if the OP is following the example code.

@nhooyr nhooyr reopened this Jan 10, 2018
arp242 added a commit that referenced this issue Aug 1, 2022
@arp242
Fix up this PR after merge
fe3d62d 
The timeout for unix.Kevent() is causing issues; every 100ms it will do a new
unix.Kevent() syscall, which isn't too efficient: even if you have just one
change an hour, you will still keep calling kevent() ten times per second,
resulting in a needlessly high CPU usage.

Without a timeout, kevent() will block indefinitely until there are some events,
which is much more efficient. We can't just remove the timout however, since we
can't interrupt the kevent() call on FreeBSD and NetBSD, and it will hang
forever. This issue is described in more detail here:
#262 (comment)

To solve this we register a new kevent() with the file descriptor set to the
closepipe; when this pipe is closed an event is sent and kevent() will stop
blocking.

This is a rebased version of #124.

Fixes #89
Fixes #237
Fixes #333
Supersedes and closes #124
Supersedes and closes #262
Supersedes and closes #334
@arp242 arp242 mentioned this issue Aug 1, 2022
Merged
arp242 added a commit that referenced this issue Aug 6, 2022
@arp242 @fjl
kqueue: remove timeout from unix.Kevent() (#480)
4b43fad 
The timeout for unix.Kevent() is causing issues; every 100ms it will do a new
unix.Kevent() syscall, which isn't too efficient: even if you have just one
change an hour, you will still keep calling kevent() ten times per second,
resulting in a needlessly high CPU usage.

Without a timeout, kevent() will block indefinitely until there are some events,
which is much more efficient. We can't just remove the timout however, since we
can't interrupt the kevent() call on FreeBSD and NetBSD, and it will hang
forever. This issue is described in more detail here:
#262 (comment)

To solve this we register a new kevent() with the file descriptor set to the
closepipe; when this pipe is closed an event is sent and kevent() will stop
blocking.

This is a rebased version of #124.

Fixes #89
Fixes #237
Fixes #333
Supersedes and closes #124
Supersedes and closes #262
Supersedes and closes #334

Co-authored-by: Felix Lange <fjl@twurst.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathany nathany

Labels
macOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kqueue: remove timeout from unix.Kevent() fsnotify/fsnotify
5 participants
@nathany @pquerna @ryanwalls @omeid @nhooyr