Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

illumos build fails in CI #515

Closed
arp242 opened this issue Oct 13, 2022 · 2 comments
Closed

illumos build fails in CI #515

arp242 opened this issue Oct 13, 2022 · 2 comments
Labels

Comments

@arp242
Copy link
Member

arp242 commented Oct 13, 2022

CI build on main fails for illumos with:

--- FAIL: TestAdd (0.00s)
    --- FAIL: TestAdd/permission_denied (0.23s)
        fsnotify_test.go:918: error is nil

Bit odd, because it works for me if I run it in illumos 🤔

[~/fsnotify]% go test -run TestAdd/permission_denied -v
=== RUN   TestAdd
=== RUN   TestAdd/permission_denied
=== PAUSE TestAdd/permission_denied
=== CONT  TestAdd/permission_denied
--- PASS: TestAdd (0.00s)
    --- PASS: TestAdd/permission_denied (0.20s)
PASS
ok      github.com/fsnotify/fsnotify    0.213s
[~/fsnotify]% uname -a
SunOS omnios 5.11 omnios-r151042-2a01bcc289 i86pc i386 i86pc

Maybe an illumos version thing? Two builds failed on this error, so doesn't seem like a fluke in the CI.

@nshalman

@arp242 arp242 added the illumos label Oct 13, 2022
@nshalman
Copy link
Contributor

This is due to the CI test running as root. The permissions don't stop root from accessing things. We probably need an improved CI solution for illumos...

#371 (comment)

@arp242
Copy link
Member Author

arp242 commented Oct 13, 2022

Ah, right; I actually fixed that before for the BSD builds by adding a user and then using su to run it like that: https://github.com/fsnotify/fsnotify/blob/main/.github/workflows/test.yml#L109 – I should have remembered.

Should do the same for illumos. I'll look in to it later.

arp242 added a commit that referenced this issue Oct 13, 2022
arp242 added a commit that referenced this issue Oct 13, 2022
arp242 added a commit that referenced this issue Oct 13, 2022
@arp242 arp242 closed this as completed in acadbbe Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants