Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macos: retry if open() returns EINTR #475

Merged
merged 1 commit into from Jul 30, 2022
Merged

macos: retry if open() returns EINTR #475

merged 1 commit into from Jul 30, 2022

Conversation

arp242
Copy link
Member

@arp242 arp242 commented Jul 29, 2022

Retry the unix.Open() if the error returned is EINTR; looking around the
web it seems many systems handle it like this. This is also what
os.Open() does:
golang/go@50d0ee0

Fixes #354

NOTE: Please do not open a pull request that adds or changes the public API without giving consideration to all supported operating systems.

What does this pull request do?

Where should the reviewer start?

How should this be manually tested?

Retry the unix.Open() if the error returned is EINTR; looking around the
web it seems many systems handle it like this. This is also what
os.Open() does:
golang/go@50d0ee0

Fixes #354
@arp242 arp242 merged commit ca0e2f4 into main Jul 30, 2022
@arp242 arp242 deleted the macos-eintr branch July 30, 2022 10:54
@shogo82148 shogo82148 mentioned this pull request Mar 6, 2024
25 tasks
shogo82148 pushed a commit to shogo82148/fsnotify that referenced this pull request Mar 6, 2024
port of fsnotify/fsnotify#475

Retry the unix.Open() if the error returned is EINTR; looking around the
web it seems many systems handle it like this. This is also what
os.Open() does:
golang/go@50d0ee0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS Big Sur: Retry file open when error is EINTR
1 participant