New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FreeBSD testing in Github Actions (fix #389) #419
Conversation
Thank you!! |
Yeah, the reason for being slow is that it downloads a full VM image, extract it and boots it up before doing anything. I think 5 minutes are bearable, though |
I wonder if there's a clever way to make it somehow depend on the cross-compilation target so that if it wouldn't build we won't waste time spinning up the VM for testing... EDIT: Or really just any/all of the compilation targets. If any compilation target is broken, that's reason enough to skip the expensive VM test. Perhaps:
Reference https://stackoverflow.com/questions/58457140/dependencies-between-workflows-on-github-actions |
Well, if we do |
The builds are very fast. I see the argument on the other side though. |
That the VM build starts later? Maybe more waiting |
How can we get builds to run on external pull requests like this? We don't have any secrets to worry about leaking. |
😄 #415 should do it. Alternately we could favor |
Given @nathany's approval I think we should merge this. If the build times become onerous we can revisit moving them out to the forthcoming slow-tests that I'm planning for illumos. Better to err on the side of testing. |
Fix #389