Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move example usage to the readme #329

Merged
merged 1 commit into from Mar 11, 2020
Merged

Move example usage to the readme #329

merged 1 commit into from Mar 11, 2020

Conversation

nathany
Copy link
Contributor

@nathany nathany commented Mar 11, 2020 •
edited

What does this pull request do?

Move example usage to the readme. It may resolve issue #328 by removing the reference to github.com/fsnotify/fsnotify

Where should the reviewer start?

readme

How should this be manually tested?

go test

cpuguy83
cpuguy83 approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathany
Copy link
Contributor Author

nathany commented Mar 11, 2020

ignoring #330 for now and merging this

@nathany nathany merged commit 45d7d09 into master Mar 11, 2020
@nathany nathany deleted the example branch March 11, 2020 17:35
@smooth80
Copy link

smooth80 commented Jul 5, 2021

@fsnotify fsnotify locked and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nathany @smooth80 @cpuguy83