Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open files with CLOEXEC #273

Merged
merged 3 commits into from Oct 5, 2019
Merged

Open files with CLOEXEC #273

merged 3 commits into from Oct 5, 2019

Conversation

linxiulei
Copy link
Contributor

@linxiulei linxiulei commented Oct 25, 2018 •
edited

What does this pull request do?

Fix #272

Where should the reviewer start?

How should this be manually tested?

No

cpuguy83
cpuguy83 approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83
Copy link
Contributor

Looks like darwin got support in 10.7, and (free) BSD in 8.2... seems ok to add this in implicitly.

@nathany
Copy link
Contributor

nathany commented Oct 5, 2019

Thanks

@nathany nathany merged commit 924410f into fsnotify:master Oct 5, 2019
@dims dims mentioned this pull request Apr 8, 2020
Merged
@johejo johejo mentioned this pull request Dec 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Race with golang exec
3 participants
@linxiulei @cpuguy83 @nathany