Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#234] t.Fatalf -> t.Errorf in go routines #266

Merged
merged 2 commits into from Aug 30, 2018
Merged

[#234] t.Fatalf -> t.Errorf in go routines #266

merged 2 commits into from Aug 30, 2018

Conversation

gdey
Copy link
Contributor

@gdey gdey commented Aug 30, 2018

What does this pull request do?

The documentation for t.FailNow (which is called by t.Fatalf) states
that it should not be called in go routines outside of the test go
routine.

Where should the reviewer start?

How should this be manually tested?

no.

The documentation for t.FailNow (which is called by t.Fatalf) states
that it should not be called in go routines outside of the test go
routine.
@nathany nathany merged commit 8ba2b19 into master Aug 30, 2018
@nathany nathany deleted the redo_234 branch August 30, 2018 20:59
radu-munteanu pushed a commit to radu-munteanu/fsnotify that referenced this pull request Feb 25, 2019
The documentation for t.FailNow (which is called by t.Fatalf) states
that it should not be called in go routines outside of the test go
routine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants