Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestInotifyOverflow #265

Merged
merged 1 commit into from Aug 30, 2018
Merged

Fix TestInotifyOverflow #265

merged 1 commit into from Aug 30, 2018

Conversation

matthias-stone
Copy link
Contributor

  • Queued inotify events could have been read by the test before max_queued_events was hit

What does this pull request do?

Fixes a race condition in the TestInotifyOverflow test

Where should the reviewer start?

Pretty small change

How should this be manually tested?

go test -run TestInotifyOverflow -count 10 on a multicore machine

* Queued inotify events could have been read by the test before max_queued_events was hit
Copy link
Contributor

@gdey gdey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdey gdey closed this Aug 30, 2018
@gdey gdey reopened this Aug 30, 2018
@nathany nathany merged commit 70cc4a1 into master Aug 30, 2018
@nathany nathany deleted the fix-inotify-test branch August 30, 2018 20:03
radu-munteanu pushed a commit to radu-munteanu/fsnotify that referenced this pull request Feb 25, 2019
* Queued inotify events could have been read by the test before max_queued_events was hit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants