Only build fsevents on macOS #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajivshah3
force-pushed
the
fix/only-build-on-macos
branch
from
0ee91db
to
9a50fcc
Compare
pipobscure
approved these changes
Apr 24, 2020
|
Any chance we can get an estimate better than "soonish"? |
|
It’s merged an will be published this weekend (hopefully). |
|
Thanks much for doing this work and merging it in! |
|
I think it was published just 2 hours ago: https://www.npmjs.com/package/fsevents/v/1.2.13 |
|
@rajivshah3 Ah, OK. I was looking here; my mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #301
According to the npm docs, if a
binding.gypis detected,npmwill runnode-gyp rebuildby default unless aninstallscript is specified. For some reason, even though'OS=="mac"'is specified in thebinding.gyp, it builds on Windows anyway. This PR adds aninstallscript that checks the platform and only runsnode-gyp rebuildif a macOS environment is detected.