Node.js v12 support for v1.x #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
7 tasks
DanielSchaffer
pushed a commit
to Instawork/hyperview
that referenced
this pull request
Jan 27, 2020
…work - initially disable newly breaking rules - add resolution for fsevents to prevent build errors in NodeJS 12 - see fsevents/fsevents#274
DanielSchaffer
pushed a commit
to Instawork/hyperview
that referenced
this pull request
Jan 27, 2020
…work - initially disable newly breaking rules - add resolution for fsevents to prevent build errors in NodeJS 12 - see fsevents/fsevents#274 closes #37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced v8::Handle with v8::Local as in lovell/sharp@aa9b328
Also added context as per https://nodejs.org/api/addons.html#addons_wrapping_c_objects
No idea how to build it locally, so i am creating this PR in attempt to check if it will build in travis