Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where feed is matched anywhere in the permalink #935

Closed
wants to merge 2 commits into from
Closed

Fix issue where feed is matched anywhere in the permalink #935

wants to merge 2 commits into from

Conversation

tobeycodes
Copy link

@tobeycodes tobeycodes commented Oct 27, 2022

What:

Update the regex for the Yoast plugin to determine when to transform links. Currently we have canonical urls pointing to the WP site that contain the word feed.

Why:

The regex pattern only matches wp-* links at the start of the string where as feed, comments and xmlrc anywhere in the string.

See the regex example of how it currently works https://regex101.com/r/zcxmVX/1

How:

I updated the regex to match everything from the start of the string so that feed-asd will match but asd-feed won't

Tasks:

Unrelated Tasks

  • TSDocs
  • TypeScript
  • Unit tests
  • End to end tests
  • TypeScript tests
  • Update starter themes
  • Update other packages
  • Update community discussions

Additional Comments

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2022

🦋 Changeset detected

Latest commit: 6589330

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@luisherranz
Copy link
Member

@tobeycodes, could you please add a full description of the PR? It is difficult to infer what the problem is and how you solved it by just looking at the PR title and the code change.

@tobeycodes
Copy link
Author

@luisherranz Sorry about that. I updated it. To be clear we are able to update this setting ourselves when importing packages so it is not a priority to merge but I wanted to create the pull request so if anyone else comes across the same issue they see the fix.

@luisherranz
Copy link
Member

Ok, got it now. Thanks @tobeycodes 🙂

@tobeycodes
Copy link
Author

Closing this since it has been open for a while without movement. Thanks.

@tobeycodes tobeycodes closed this Mar 17, 2023
@tobeycodes tobeycodes deleted the patch-3 branch March 17, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants