Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make @frontity/google-ad-manager AMP-aware [8pt] #714

Open
SantosGuillamot opened this issue Feb 9, 2021 · 0 comments · May be fixed by #822
Open

Make @frontity/google-ad-manager AMP-aware [8pt] #714

SantosGuillamot opened this issue Feb 9, 2021 · 0 comments · May be fixed by #822
Assignees
@DAreRodz
Labels
amp
Projects
AMP feature Sprint 11 Sprint 12 Sprint 13

Comments

@SantosGuillamot
Copy link
Member

This is needed for AMP feature. For full context please check out the final Implementation proposal.

The AMP framework uses a special syntax for the ads, so we have to make this package AMP-aware to load the correct content if the AMP package is active.
@SantosGuillamot SantosGuillamot added this to To do in AMP feature via automation Feb 9, 2021
@SantosGuillamot SantosGuillamot added this to To do in Sprint 11 via automation Feb 11, 2021
@SantosGuillamot SantosGuillamot moved this from To do to Backlog in Sprint 11 Feb 11, 2021
@SantosGuillamot SantosGuillamot added this to To do in Sprint 12 via automation Feb 25, 2021
@SantosGuillamot SantosGuillamot added this to To do in Sprint 13 via automation Mar 18, 2021
@SantosGuillamot SantosGuillamot moved this from To do to In progress in AMP feature Mar 18, 2021
@DAreRodz DAreRodz mentioned this issue Mar 24, 2021
Merged
10 tasks
@DAreRodz DAreRodz moved this from To do to In progress in Sprint 13 May 13, 2021
@DAreRodz DAreRodz self-assigned this May 13, 2021
@DAreRodz DAreRodz linked a pull request May 18, 2021 that will close this issue
Draft
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DAreRodz DAreRodz

Labels
amp
Projects
AMP feature
  
In progress
Sprint 13
  
In progress
Sprint 11
  
Backlog
Sprint 12
  
To do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Google Ad Manager AMP aware frontity/frontity
2 participants
@DAreRodz @SantosGuillamot