[Bug]: Typings for puppeteerArgs
are using the incorrect type from Puppeteer
#162
Labels
bug
Something isn't working
This was suddenly brought to my attention when bumping the package from v3.2.0 to v3.2.3 in favware/archangel#103. Felt it was very strange because even as recent as 6 days ago I saw you commented on an issue to use
args
and I couldn't possibly image Puppeteer removing such a critical option.A bunch of digging later (godbless having access to cs.github.com so I could search both this repo and puppeteer's) and I found out that way back in February 2021 Puppeteer changed the TS types for
LaunchOptions
: puppeteer/puppeteer#6888All that said, I tracked down the bug and opened a PR to fix it but for tracking and formalities sake I also wanted to first open this issue. I figured it might also help anyone who runs into the same issue when they go searching.
The text was updated successfully, but these errors were encountered: