Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Typings for puppeteerArgs are using the incorrect type from Puppeteer #162

Closed
favna opened this issue Feb 14, 2022 · 2 comments · Fixed by #163
Closed

[Bug]: Typings for puppeteerArgs are using the incorrect type from Puppeteer #162

favna opened this issue Feb 14, 2022 · 2 comments · Fixed by #163
Labels
bug Something isn't working

Comments

@favna
Copy link
Contributor

favna commented Feb 14, 2022

This was suddenly brought to my attention when bumping the package from v3.2.0 to v3.2.3 in favware/archangel#103. Felt it was very strange because even as recent as 6 days ago I saw you commented on an issue to use args and I couldn't possibly image Puppeteer removing such a critical option.

A bunch of digging later (godbless having access to cs.github.com so I could search both this repo and puppeteer's) and I found out that way back in February 2021 Puppeteer changed the TS types for LaunchOptions: puppeteer/puppeteer#6888

All that said, I tracked down the bug and opened a PR to fix it but for tracking and formalities sake I also wanted to first open this issue. I figured it might also help anyone who runs into the same issue when they go searching.

favna added a commit to favna/node-html-to-image that referenced this issue Feb 14, 2022
@frinyvonnick frinyvonnick added the bug Something isn't working label Feb 15, 2022
@frinyvonnick
Copy link
Owner

Hello @favna 👋

Thank you for opening this issue and taking time to explain it ❤️

frinyvonnick pushed a commit that referenced this issue Feb 15, 2022
@frinyvonnick
Copy link
Owner

This has been released in v3.2.4 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants