Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Default variant #25

Merged
merged 2 commits into from Dec 25, 2022
Merged

Conversation

edfloreshz
Copy link
Collaborator

  • Added Default variant to comply with the FreeDesktop specification.
  • macOS and Windows remain using only Light and Dark variants.

Closes #23

- Added `Default` option to comply with the FreeDesktop specification.
- macOS and Windows remain using only `Light` & `Dark` variants.
}
Mode::Light
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean:

Suggested change
Mode::Light
Mode::Default

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default was added to comply with the FreeDesktop specification, I don't think it really applies to Windows or macOS.

Copy link
Owner

@frewsxcv frewsxcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@frewsxcv frewsxcv merged commit d87d9be into frewsxcv:master Dec 25, 2022
@frewsxcv
Copy link
Owner

Version 1.0.0 published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API should be able ti indicate if dark/light mode can't be detected
2 participants