Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WLED latest version fetched on every update #1197

Open
Xitee1 opened this issue Dec 23, 2023 · 10 comments
Open

WLED latest version fetched on every update #1197

Xitee1 opened this issue Dec 23, 2023 · 10 comments

Comments

@Xitee1
Copy link

Xitee1 commented Dec 23, 2023

Problem/Motivation

Related to: home-assistant/core#93475
Every time the state gets updated, the update sensor in HA goes unavailable. It looks like this is caused by this library as every time this

async def update(self, *, full_update: bool = False) -> Device: # noqa: PLR0912
function is called, the version is fetched from GitHub.

Expected behavior

After the versions have been fetched, cache and re-use them (unless the full_update parameter is set to True).

Actual behavior

Version gets fetched again.

Steps to reproduce

  • Use the WLED integration in HomeAssistant and toggle a the light switch
  • Watch how the firmware update sensor goes to Unkown
Copy link

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Jan 23, 2024
@Xitee1
Copy link
Author

Xitee1 commented Jan 23, 2024

Still an issue.

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Jan 24, 2024
Copy link

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Feb 23, 2024
@Xitee1
Copy link
Author

Xitee1 commented Feb 23, 2024

Still an issue.

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Feb 24, 2024
@DL099
Copy link

DL099 commented Mar 10, 2024

Having the same issue
image

Copy link

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Apr 10, 2024
@Xitee1
Copy link
Author

Xitee1 commented Apr 10, 2024

Still an issue.

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Apr 11, 2024
@Xitee1
Copy link
Author

Xitee1 commented Apr 23, 2024

I have no idea if this is related but today GitHub has massively throttled the download speed of a release file. After turning on my VPN (so changing my IP address), the down speed jumped from 200kb/s to so fast that the 150mb file was finished before I had time to look at the speed.. so about 50mb/s I think (max possible).
This was not related to my GH account since it was also that slow without being signed in. It was limited by my IP address.

Nevertheless, this issue should really get addressed to reduce the API call amount on GH servers.

Copy link

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label May 24, 2024
@Xitee1
Copy link
Author

Xitee1 commented May 24, 2024

Still an issue.

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants